Review Request 124871: Fix opening krunner by typing on empty desktop

David Edmundson david at davidedmundson.co.uk
Fri Aug 21 20:16:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124871/#review84159
-----------------------------------------------------------

Ship it!


and now I understand why applets didn't seem to be handling the keys first like we discussed on IRC. Events go to the window object first before being dispatched to the activeFocusItem in QQuickWindow::keyPressEvent...good stuff! 


+100

- David Edmundson


On Aug. 21, 2015, 6:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124871/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 6:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 347872
>     https://bugs.kde.org/show_bug.cgi?id=347872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Let the event propagate first and if nobody accepted it we'll open KRunner
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp aef828b 
> 
> Diff: https://git.reviewboard.kde.org/r/124871/diff/
> 
> 
> Testing
> -------
> 
> Typing into a sticky note does not bring up KRunner but typing after clicking an empty area works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150821/05035a4e/attachment.html>


More information about the Plasma-devel mailing list