Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

Harald Sitter sitter at kde.org
Fri Aug 21 10:09:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124863/
-----------------------------------------------------------

(Updated Aug. 21, 2015, 10:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit b2994a0f0ff3d39fecc651f9f088f5a7967e0445 by Harald Sitter to branch Plasma/5.4.


Bugs: 351550
    https://bugs.kde.org/show_bug.cgi?id=351550


Repository: plasma-desktop


Description
-------

Desktop files changed name during KDE Frameworks 5 porting which renders
our initial favorite list defunct. By adding the new names as well as
the old ones we'll pick which ever one is actually installed on first start
such that Plasma 5.4 will also behave correctly with Applications <15.08.

BUG: 351550


Diffs
-----

  applets/kickoff/core/favoritesmodel.cpp 8da20f41c57c890d5383548b3cd8264373ef725f 

Diff: https://git.reviewboard.kde.org/r/124863/diff/


Testing
-------

- builds
- wiped kickoffrc (and kde4 kickoffrc)
- started plasmashell -> only shows expected entries picking whichever is available
- adding a new fav to get a new kickoffrc written -> only entries are the actually found ones


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150821/ef139ef0/attachment.html>


More information about the Plasma-devel mailing list