Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

[Harald Sitter]

> On Aug. 21, 2015, 8:26 a.m., Kai Uwe Broulik wrote:
> > applets/kickoff/core/favoritesmodel.cpp, line 133
> > <https://git.reviewboard.kde.org/r/124863/diff/1/?file=397018#file397018line133>
> >
> >     Should we "future-proof" that also?

Ah whoops


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124863/#review84130
-----------------------------------------------------------


On Aug. 21, 2015, 8:27 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124863/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 8:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 351550
>     https://bugs.kde.org/show_bug.cgi?id=351550
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Desktop files changed name during KDE Frameworks 5 porting which renders
> our initial favorite list defunct. By adding the new names as well as
> the old ones we'll pick which ever one is actually installed on first start
> such that Plasma 5.4 will also behave correctly with Applications <15.08.
> 
> BUG: 351550
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/favoritesmodel.cpp 8da20f41c57c890d5383548b3cd8264373ef725f 
> 
> Diff: https://git.reviewboard.kde.org/r/124863/diff/
> 
> 
> Testing
> -------
> 
> - builds
> - wiped kickoffrc (and kde4 kickoffrc)
> - started plasmashell -> only shows expected entries picking whichever is available
> - adding a new fav to get a new kickoffrc written -> only entries are the actually found ones
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150821/e865e04f/attachment-0001.html>