Review Request 124841: Fix some spacing issues in NM applet

[Jan Grulich]

> On Srp. 20, 2015, 5:56 odp., Jan Grulich wrote:
> > Doesn't look same, with your patch there is now quite a big space between details/plotter and the tab widget.
> 
> Aleix Pol Gonzalez wrote:
>     It would be nice if both of you offered screenshots... :)
> 
> David Edmundson wrote:
>     I offer maths!
>     
>     plot view was:
>     old code was 1g/3 + 1g/2    or in other words 5g/6
>     
>     I changed it to large spacing which is 1g
>     
>     details view was:
>     1g/3 + a non working 1g/3
>     
>     again, I changed this to 1g. which is kinda off I guess.
>     
>     I'll redo it.

Screenshots:
![Previous version](https://jgrulich.fedorapeople.org/old.png)
![New version](https://jgrulich.fedorapeople.org/new.png)


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124841/#review84099
-----------------------------------------------------------


On Srp. 20, 2015, 5:27 odp., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124841/
> -----------------------------------------------------------
> 
> (Updated Srp. 20, 2015, 5:27 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Plotter had a top margin of gridUnit / 2
> axis labels assumed a topMargin of gridUnit /2, so labels would
> sometimes clip the horizontal line.
> 
> Both weren't needed anyway as as we can just increase the topMargin of
> the parent item instead (the one at line 285), so I did that and ported it to the more
> semantic largeSpacing at the same time.
> 
> Also removed a topMargin in details view which had no top anchor so it
> wasn't doing anything.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ConnectionItem.qml 047cc9f3e4aefdd9457038ed312cdbae7e8f8a8f 
> 
> Diff: https://git.reviewboard.kde.org/r/124841/diff/
> 
> 
> Testing
> -------
> 
> looks basically the same...
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150820/094220e9/attachment-0001.html>