Review Request 124840: Fix loading/saving in KDED kcm

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124840/#review84100
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 20, 2015, 4:46 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124840/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 4:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346848 and 347429
>     https://bugs.kde.org/show_bug.cgi?id=346848
>     https://bugs.kde.org/show_bug.cgi?id=347429
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This fixes loading/saving of the autoload status of KDED startup services in the KCM.
> 
> Loading was broken due to a QString being passed to autoloadEnabled(), instead of a KPluginMetaData.
> 
> Saving was broken due to comparing KPluginMetaData.metaDataFileName() to treeitem->data(LibraryRole). This didn't work due to KPluginMetaData.metaDataFileName() containing the path in addition to the plugin/library name. This was solved by using KPluginMetaData.pluginId() instead of KPluginMetaData.metaDataFileName().
> 
> 
> Diffs
> -----
> 
>   kcms/kded/kcmkded.cpp 41ad191 
> 
> Diff: https://git.reviewboard.kde.org/r/124840/diff/
> 
> 
> Testing
> -------
> 
> The correct booleans from the kded5rc file are now loaded when opening the KCM.
> 
> Checking/unchecking the "Use" checkbox and clicking "Apply" now properly saves the checkstate in the kded5rc file.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150820/9a827387/attachment.html>