Review Request 124838: Fix ksmserver launching shell scripts

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124838/
-----------------------------------------------------------

(Updated Aug. 20, 2015, 2:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit a75748f7895fcfcd340572e848f9f001d3d9adc9 by David Edmundson to branch Plasma/5.4.


Repository: plasma-workspace


Description
-------

QProcess::startDetached doesn't work on shell scripts, presumably
because it tries to daemonize them.

Porting to QProcess seems to fix this. As KSMServer stays around forever
this shouldn't result in any behavioural change.


Diffs
-----

  ksmserver/startup.cpp bd80417b25325214199a1cc109f6ea2b2a24ce98 

Diff: https://git.reviewboard.kde.org/r/124838/diff/


Testing
-------

added some shell scripts with
#/bin/sh
echo hello > /tmp/hello

was greeted pleasantly.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150820/ec25c498/attachment-0001.html>