Review Request 124837: Fix autostart script KCM

David Edmundson david at davidedmundson.co.uk
Thu Aug 20 13:15:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124837/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

.autostart only has .desktop files
We saved our scripts there, but the code deliberately made sure they weren't loaded back because they're not executed when there. 

It appears shell scripts are exectued from another location, so I've separated where shell scripts get lodaed and where .desktop files get loaded in the code, which IMHO makes it all a bit simpler.

BUG: 350135


Diffs
-----

  kcms/autostart/autostart.h 11675e1eaf10fd4af1c53a4e7173124a31f80255 
  kcms/autostart/autostart.cpp b102323a3ca6fd8e8238615e534ae8a701ac5590 

Diff: https://git.reviewboard.kde.org/r/124837/diff/


Testing
-------

Saved some scripts, they all appeared where they should be

debug in ksmserver shows everything being loaded properly....however shell scripts don't actually work because of another bug in ksmserver. Brilliant.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150820/f6ed5fb8/attachment.html>


More information about the Plasma-devel mailing list