Review Request 124823: Handle an invalid case in PluginLoader

Sebastian Kügler sebas at kde.org
Thu Aug 20 10:55:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124823/#review84086
-----------------------------------------------------------

Ship it!


Should be fine, invalid KPluginInfo is a common cause for crashes around that codepath, a warning will surely help making debugging a bit easier.

- Sebastian Kügler


On Aug. 19, 2015, 4 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124823/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 4 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Handle an invalid case in PluginLoader
> 
> 
> Diffs
> -----
> 
>   src/plasma/pluginloader.cpp f01341a876484cdc2ce4d3bf5f28ef4b9e05f709 
> 
> Diff: https://git.reviewboard.kde.org/r/124823/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150820/e81c9c62/attachment.html>


More information about the Plasma-devel mailing list