killing kde4workspace usage in oxygen

[Harald Sitter]

On Wed, Aug 19, 2015 at 2:58 PM, Hugo Pereira Da Costa
<hugo.pereira at free.fr> wrote:
>
>
> On 19/08/2015 14:42, Harald Sitter wrote:
>>
>> On Wed, Aug 19, 2015 at 2:20 PM, Hugo Pereira Da Costa
>> <hugo.pereira at free.fr> wrote:
>>>
>>> On 08/19/2015 12:51 PM, Harald Sitter wrote:
>>>>
>>>> Heya,
>>>>
>>>> oxygen 5.4 and master complain about
>>>>
>>>>> -- Could NOT find KDE4Workspace (missing:  KDE4Workspace_CONFIG)
>>>>> (Required is at least version "4.9.80")
>>>>
>>>> it is apparently only used to build the legacy-kwin decoration.
>>>>
>>>> Seeing as kde-workspace LTS is expiring this month (i.e. no further
>>>> support) I think we should kill its usage in oxygen for Plasma 5.4 and
>>>> onwards.
>>>>
>>>> HS
>>>
>>> Hi Harald,
>>>
>>> I'm confused. Here at least, KDE4Workspace is needed when building oxygen
>>> only when building with -DUSE_KDE4=1.
>>
>> Ah yes, it looking for KDE4Workspace isn't a bug. It just is a
>> nuisance as building with kde4 support (which will have to happen for
>> the foreseeable future still with plenty qt4 applications still there)
>> is complaining for no good reason.
>
> All right,
> What I can do is make it optional, and build the legacy decoration only if
> found.
> You would still get the style if not found. Would that prevent the annoyance
> ?

Just remove the decoration. We want the widget style, the window
decoration is useless as this point. The only supported kwin is the
kwin that comes with plasma5 anyway.

HS