Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/#review83981
-----------------------------------------------------------

Ship it!


Some minor comments, otherwise looks useful and good to me.


autotests/client/test_wayland_registry.cpp (line 146)
<https://git.reviewboard.kde.org/r/124734/#comment58173>

    let's



autotests/client/test_wayland_registry.cpp (line 160)
<https://git.reviewboard.kde.org/r/124734/#comment58172>

    know



src/client/registry.h (line 195)
<https://git.reviewboard.kde.org/r/124734/#comment58174>

    well-known sounds a bit weird, perhaps "already known"?


- Sebastian Kügler


On Aug. 17, 2015, 6:28 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124734/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 6:28 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> This change addresses the sometimes cumbersome to use API of Registry.
> So far to bind an interface one needed to connect to the signals when
> setting up the registry. There was no other way to get the name and
> version at a later point. This made it difficult to use one Registry
> in different parts of an Wayland application.
> 
> This change adds a convenient:
> struct AnnouncedInterface { quint32 name; quint32 version;};
> AnnouncedInterface interface(Interface) const
> QVector<AnnouncedInterface> interfaces(Interface) const
> 
> The first one is meant for interfaces like wl_shm which is normally only
> announced once. The latter one is meant for interfaces like wl_output
> for which normally multiple interfaces can get announced.
> 
> Those methods can be used without having to connect to the announced
> spy.
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_registry.cpp d3f6863f4173eab2b497391070bc6cc3f966ce1d 
>   src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
>   src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 
> 
> Diff: https://git.reviewboard.kde.org/r/124734/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150818/6b24e0db/attachment-0001.html>