Review Request 124730: [solid-device-automounter] Port to KF5

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124730/#review83792
-----------------------------------------------------------


done the KCM. not looked at kded


solid-device-automounter/kcm/CMakeLists.txt (line 7)
<https://git.reviewboard.kde.org/r/124730/#comment58019>

    you missed a thing



solid-device-automounter/kcm/DeviceAutomounterKCM.cpp (line 59)
<https://git.reviewboard.kde.org/r/124730/#comment58020>

    someone didn't know you can connect a signal to a signal...
    
    (probably not your code, don't feel you have to change it)



solid-device-automounter/kcm/DeviceModel.cpp (line 66)
<https://git.reviewboard.kde.org/r/124730/#comment58021>

    these layoutChanged bits don't belong here
    
    layoutChange is a sort of a mini modelReset() 
    
    same for the rest of this class.



solid-device-automounter/kcm/DeviceModel.cpp (line 100)
<https://git.reviewboard.kde.org/r/124730/#comment58022>

    this isn't right
    
    that's inserting two things into the model
    
    Maybe the layoutChanged was hiding it.


- David Edmundson


On Aug. 13, 2015, 7:48 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124730/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma, Solid and Torrie Fischer.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is a straight port of the solid-device-automounter from kde-runtime that was somehow lost to plasma-desktop. I didn't do git graft magic (can this be done later? ie. import kde-runtime folder here to there and then apply a diff on top?).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4717780 
>   solid-device-automounter/CMakeLists.txt PRE-CREATION 
>   solid-device-automounter/COPYING PRE-CREATION 
>   solid-device-automounter/SETTINGS PRE-CREATION 
>   solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION 
>   solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION 
>   solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION 
>   solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION 
>   solid-device-automounter/kcm/DeviceModel.h PRE-CREATION 
>   solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION 
>   solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION 
>   solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION 
>   solid-device-automounter/kcm/Messages.sh PRE-CREATION 
>   solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION 
>   solid-device-automounter/kded/CMakeLists.txt PRE-CREATION 
>   solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION 
>   solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION 
>   solid-device-automounter/kded/device_automounter.desktop PRE-CREATION 
>   solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION 
>   solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION 
>   solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION 
>   solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124730/diff/
> 
> 
> Testing
> -------
> 
> Seems to work, translations are probably broken.
> Told it to auto mount all the things, did that. Told it to mount just one thing automatically, did that. Somehow the list of non-attached devices grows even when I re-attach the same device.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150813/e694db31/attachment-0001.html>