Review Request 124727: Documentation for PlasmaComponents Menu

David Edmundson david at davidedmundson.co.uk
Thu Aug 13 12:39:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124727/#review83767
-----------------------------------------------------------


oh RB lost my comment


src/declarativeimports/plasmacomponents/qmenu.h (line 115)
<https://git.reviewboard.kde.org/r/124727/#comment57972>

    It's a more common practice to say:
    
    "This does X"
    
    rather than 
    
    "This allows doing X"


- David Edmundson


On Aug. 13, 2015, 11:31 a.m., Leszek Lesner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124727/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 11:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add documentation for declarative menu (PlasmaComponents.Menu)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qmenu.h 6cf0096 
> 
> Diff: https://git.reviewboard.kde.org/r/124727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leszek Lesner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150813/f5225c8c/attachment-0001.html>


More information about the Plasma-devel mailing list