Review Request 124695: Drop build option KWIN_BUILD_EGL

Martin Gräßlin mgraesslin at kde.org
Tue Aug 11 09:16:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124695/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 9:16 a.m.)


Status
------

This change has been marked as submitted.


Review request for kwin and Plasma.


Changes
-------

Submitted with commit c24e315a9ba7eb6b1c975bfdb5b54f83c7023a62 by Martin Gräßlin to branch master.


Repository: kwin


Description
-------

It doesn't make much sense any more as we get EGL linked and included
through epoxy anyway. Even more on Wayland it's just plain stupid to
have EGL disabled. So removing the option just simplifies our code base
without any disadvantages.


Diffs
-----

  libkwineffects/kwinglutils.cpp 66634d6795d43020e9f323af9c24d8bfae9bf4aa 
  libkwineffects/kwinconfig.h.cmake 3e34723aea5baf519c16f53afef3b21ab43efe7c 
  dbusinterface.cpp 01079a1b2a97c83e4624deafb288349ea3952c7f 
  backends/x11/x11windowed_backend.cpp 3ba9e5cd3932574daff2062a289dfd00745fa776 
  backends/wayland/CMakeLists.txt a1670a34b1f6519f6fb37bc041516bf3aec508e1 
  CMakeLists.txt 4d2aeed4f5ee9d0765e1b902ac51859e0ae1150b 
  libkwineffects/kwinglutils_funcs.h eea28c5ae4225939a3d7fe72167fea4bfe028298 
  libkwineffects/kwinglutils_funcs.cpp 4e763b7bb1c4e156b52639dd357c92c5f28e9937 
  options.cpp 39efd9de53024fb7f11d042b7877a4583350b651 
  scene_opengl.cpp 85c0b104785ee2f06b1698d8e8020e0615fdab88 

Diff: https://git.reviewboard.kde.org/r/124695/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150811/cad6e4c2/attachment-0001.html>


More information about the Plasma-devel mailing list