Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context
David Edmundson
david at davidedmundson.co.uk
Mon Aug 10 08:06:22 UTC 2015
> On Aug. 10, 2015, 7:02 a.m., Martin Gräßlin wrote:
> > Could you add a call to
> >
> > QCoreApplication::setAttribute(Qt::AA_ForceRasterWidgets);
> >
> > before showing the warning message - just to be sure that it doesn't try creating another GL context and dies on it.
on it, thanks
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review83634
-----------------------------------------------------------
On Aug. 1, 2015, 12:08 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 12:08 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Show a dialog if Plasma failed to create an OpenGL Context.
>
> remove that "shutup" option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly.
>
>
> Diffs
> -----
>
> shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f
>
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
>
>
> Testing
> -------
>
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150810/95a9d159/attachment-0001.html>
More information about the Plasma-devel
mailing list