Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

[Gregor Mi]

> On Aug. 9, 2015, 6:18 p.m., David Edmundson wrote:
> > We are not shipping commented out code. 
> > 
> > The obvious side effect is that people can't see which apps are disabled, which is why this code exists.
> > 
> > I will re-poke the VDG for comments, as they don't seem to have responded on the bug report yet.

Thanks for having a look. I am curious, is there a difference between a "disabled" app and a minimized one? If yes, how can I disable an app?


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/#review83621
-----------------------------------------------------------


On Aug. 9, 2015, 7:06 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124675/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 7:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 311991
>     https://bugs.kde.org/show_bug.cgi?id=311991
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This fixes Bug 311991. Though I am not sure if there are side effects which I am not aware of.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/Task.qml f655801ab1f7b1a9a915f35149c858f0ede22a29 
> 
> Diff: https://git.reviewboard.kde.org/r/124675/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150809/e3df1738/attachment.html>