Review Request 124655: Cosmetic surgery of the activity switcher
Marco Martin
notmart at gmail.com
Sat Aug 8 19:13:22 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124655/#review83582
-----------------------------------------------------------
code-wise seems fine, maybe being cosmetic a screenshot may be good, but looking good for me so far
- Marco Martin
On Aug. 7, 2015, 10:27 p.m., Ivan Čukić wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124655/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 10:27 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> - Refactoring the dialog handling
> - Dialogs are now truly inline
> - Fixed a few layout and positioning bugs
>
>
> Diffs
> -----
>
> desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 49e9b96
> desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml f189b4d
> desktoppackage/contents/activitymanager/ActivityItem.qml bfd83a0
> desktoppackage/contents/activitymanager/ActivityList.qml 97667a7
> desktoppackage/contents/activitymanager/ActivityManager.qml 9da8054
> desktoppackage/contents/activitymanager/StoppedActivityItem.qml c5dcb98
> desktoppackage/contents/activitymanager/static.js PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124655/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan Čukić
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150808/1a158a57/attachment.html>
More information about the Plasma-devel
mailing list