Review Request 124655: Cosmetic surgery of the activity switcher

[Ivan Čukić]

> On Aug. 8, 2015, 1:14 p.m., David Edmundson wrote:
> > desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml, line 107
> > <https://git.reviewboard.kde.org/r/124655/diff/1/?file=390926#file390926line107>
> >
> >     you can't have a rightMargin without a right anchor
> >     
> >     which I think you want, as as far as I can see this item doesn't have a size.. yet the children are based on it.

Right anchor seems to be defined - the bottom one is not (in the current master, at least :) )


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124655/#review83558
-----------------------------------------------------------


On Aug. 7, 2015, 10:27 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124655/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 10:27 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> - Refactoring the dialog handling
> - Dialogs are now truly inline
> - Fixed a few layout and positioning bugs
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 49e9b96 
>   desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml f189b4d 
>   desktoppackage/contents/activitymanager/ActivityItem.qml bfd83a0 
>   desktoppackage/contents/activitymanager/ActivityList.qml 97667a7 
>   desktoppackage/contents/activitymanager/ActivityManager.qml 9da8054 
>   desktoppackage/contents/activitymanager/StoppedActivityItem.qml c5dcb98 
>   desktoppackage/contents/activitymanager/static.js PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124655/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150808/6d0c5f62/attachment.html>