Review Request 124647: Cmake fail to parse proper taglib version

Luca Sartorelli dj3mb3 at gmail.com
Fri Aug 7 09:01:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/
-----------------------------------------------------------

(Updated Aug. 7, 2015, 9:01 a.m.)


Review request for Plasma.


Changes
-------

Update diff to use VERSION_LESS, thanks to Rex


Repository: plasma-mediacenter


Description
-------

taglib 1.4 is requested to build plasma-mediacenter
but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the test failure


Diffs (updated)
-----

  cmake/FindTaglib.cmake c23d582 

Diff: https://git.reviewboard.kde.org/r/124647/diff/


Testing
-------

Run cmake with kdesrc-build on debian strecth
taglib version correctly found and parsed
and plasma-mediacenter succesfully build


Thanks,

Luca Sartorelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150807/83be4919/attachment.html>


More information about the Plasma-devel mailing list