Review Request 124646: Let the RowLayout figure out the size of the label

Mark Gaiser markg85 at gmail.com
Thu Aug 6 15:15:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124646/#review83500
-----------------------------------------------------------

Ship it!



src/declarativeimports/plasmastyle/ButtonStyle.qml (lines 21 - 24)
<https://git.reviewboard.kde.org/r/124646/#comment57726>

    Completely unrelated, but it looks like plasma should update it's imports statements by now. We are currently at 2.5. The others are outdated as well.


Looks OK to me, ship it.

- Mark Gaiser


On aug 6, 2015, 2:48 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124646/
> -----------------------------------------------------------
> 
> (Updated aug 6, 2015, 2:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> It just works and doesn't let us make weird assumptions.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml 152d01f 
> 
> Diff: https://git.reviewboard.kde.org/r/124646/diff/
> 
> 
> Testing
> -------
> 
> Works with the Breeze lock screen and Muon Discover's MessageAction.qml.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150806/56637115/attachment.html>


More information about the Plasma-devel mailing list