Review Request 124633: Parse formfactor in KService and KPluginInfo

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124633/
-----------------------------------------------------------

(Updated Aug. 5, 2015, 10:41 p.m.)


Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure.


Changes
-------

Address comments.


Repository: kservice


Description
-------

Parse formfactor in KService and KPluginInfo

Add an accessor QStringList KPluginInfo::formFactors()

This corresponds to the X-KDE-FormFactors value in the .desktop file,
and to the "FormFactors" value in the "KPlugin" block of the json
metadata.

We already have this in KPluginMetaData, this patch brings KPluginInfo 
and KService in line with that. Previously, the keys would not be 
recognized, and thus be missing from the KPluginMetaData if created 
through a KPluginInfo or a KService. This patch fixes this inconsistent
behaviour.

Also bump the sycoca version.


Diffs (updated)
-----

  autotests/fakeplugin.desktop 200f023 
  autotests/fakeplugin.json de4aed9 
  autotests/kplugininfotest.cpp d99b92a 
  autotests/kservicetest.h 380cf7b 
  autotests/kservicetest.cpp 2c71331 
  src/services/kplugininfo.h 7b98576 
  src/services/kplugininfo.cpp 56dc0b4 
  src/services/kservice.cpp 3639a28 
  src/services/kservice_p.h bf59f38 
  src/sycoca/ksycoca.cpp 32d1689 

Diff: https://git.reviewboard.kde.org/r/124633/diff/


Testing
-------

Added new tests, no problems.

ksycocathreadtest currently fails, but this is unrelated (also in master without this patch).


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150805/748b250c/attachment-0001.html>