Review Request 124585: Add pretty user switcher

[Kai Uwe Broulik]

> On Aug. 2, 2015, 10:51 nachm., David Edmundson wrote:
> > I like the idea.
> > 
> > Would it be better UI if we moved "New Session" into the "Change Session" in the current lock screen so that they're both identical?
> > 
> > /IF/ we did do that then we can re-use the QML file completely; and probably even launch kscreenlocker_greet from ksmserver just with an extra arg to go directly to the switch session page?
> 
> Marco Martin wrote:
>     yeah, they should really have the same behavior and use the same code..
>     I'm wondering consistency-wise if it shouldn't actually lock the screen and just load automatically the lockscreen change sesison screen.

I would still want that thing to be a logout dialog style thing and not abuse the lock screen for that.
I'll try to split the Session stuff out of kscreenlocker and make it a separate import and then we can use it from both places and share as much code as possible.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124585/#review83355
-----------------------------------------------------------


On Aug. 1, 2015, 10:38 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124585/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 10:38 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds a user switcher dialog borrowing elements from the lock screen and log out dialog. I never understood why KRunner was used for that.
> 
> It is not yet hooked up to the system (would make KRunner's "switchUser" interface forward that to KSMServer so everybody using it (eg. kickoff) would continue to work without adjustments). To test it run qdbus org.kde.ksmserver /KSMServer openSwitchUserDialog
> 
> When it opens it defaults to "New Session", from an interaction POV the list view behaves like the one on the lock screen.
> 
> It locks the screen when switching users only when the user has enabled the lock screen (might need a separate option for that?) That unconditional locking on session switching has turned out to be a major annoyance.
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt a0c8852 
>   ksmserver/org.kde.KSMServerInterface.xml 3680ed7 
>   ksmserver/server.h 2176aa1 
>   ksmserver/server.cpp b73b792 
>   ksmserver/switchuserdialog.h PRE-CREATION 
>   ksmserver/switchuserdialog.cpp PRE-CREATION 
>   lookandfeel/contents/components/UserList.qml 778d8ea 
>   lookandfeel/contents/components/UserSelect.qml 007a118 
>   lookandfeel/contents/userswitcher/UserSwitcher.qml e69de29 
> 
> Diff: https://git.reviewboard.kde.org/r/124585/diff/
> 
> 
> Testing
> -------
> 
> Looks pretty, switching to a new or existing session works.
> 
> Btw, weren't we able to click outside the dialog to dismiss it in 4.x? Seems broken for the logout dialog as well.
> 
> 
> File Attachments
> ----------------
> 
> User switcher
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/03dc2669-bee4-43a5-be11-350ba72417a6__fancyswitchuser1.jpg
> User switcher with icons
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/bb4d5a64-2ac5-4f61-9fd7-38d222a1f74f__fancyswitchuser2.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150804/393099d2/attachment.html>