Review Request 123877: [digital-clock] Bring back font family option
Kai Uwe Broulik
kde at privat.broulik.de
Mon Aug 3 18:12:23 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123877/
-----------------------------------------------------------
(Updated Aug. 3, 2015, 6:12 nachm.)
Review request for Plasma and KDE Usability.
Summary (updated)
-----------------
[digital-clock] Bring back font family option
Bugs: 348072
https://bugs.kde.org/show_bug.cgi?id=348072
Repository: plasma-workspace
Description (updated)
-------
This restores the custom font family option; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible?
Diffs (updated)
-----
applets/digital-clock/package/contents/config/main.xml 8b0872b
applets/digital-clock/package/contents/ui/DigitalClock.qml 696903a
applets/digital-clock/package/contents/ui/configAppearance.qml cc1acbe
Diff: https://git.reviewboard.kde.org/r/123877/diff/
Testing (updated)
-------
The "Default" font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken.
File Attachments
----------------
The clock
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png
Settings
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150803/1ea7b949/attachment.html>
More information about the Plasma-devel
mailing list