Review Request 124449: [digital-clock] Introduce new layouting state for small panels

Martin Klapetek martin.klapetek at gmail.com
Mon Aug 3 14:10:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124449/
-----------------------------------------------------------

(Updated Aug. 3, 2015, 2:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
-------

Submitted with commit 33395e8e4200a5d61e834cdd44a4088ef1b28e4b by Martin Klapetek to branch master.


Bugs: 348072
    https://bugs.kde.org/show_bug.cgi?id=348072


Repository: plasma-workspace


Description
-------

One of the most reported bugs wrt digital clock is that the second line
text (date or timezone) is unreadable on small panels so this adds new
state to the clock applet that lays things horizontally when the panel
is too small to show text with the "small" font (set in system settings).

When there is a date displayed, a delimiter is put in between to allow
easier and faster spotting the time (as on a first glance there is just
a bunch of numbers, so quickly orienteering is super important). I used
the dot symbol first but then went for pipe which I think looks more clean;
see screenshots for comparison.

I've made a quick video showing the state changes,
see https://www.youtube.com/watch?v=t7w0k8H22h4 - it shows the bullet
delimiter and a bit wrong spacing which is now fixed.


Diffs
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078 

Diff: https://git.reviewboard.kde.org/r/124449/diff/


Testing
-------

Everything works as it used and now with small panel things are layed
horizontally, see video above.


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/0173583e-08ec-455b-9417-42d390aac81d__clock-rect-delimiter2.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150803/18eb54a9/attachment.html>


More information about the Plasma-devel mailing list