Review Request 124580: Use the better implementation of IconDialog

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124580/
-----------------------------------------------------------

(Updated Aug. 2, 2015, 10:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 7a514de428ef1da5fa14dc004775c21b3b710e7d by David Edmundson to branch master.


Repository: plasma-desktop


Description
-------

For some reason we have two IconDialog's exported to QML.

One in KDeclarative, one in Plasma-Frameworks/platformcomponents.

The one in plasmacomponents performs an exec() in the main thread from
QML which is a very bad idea. the one in kdeclarative is good.

BUG: 350864


Diffs
-----

  desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 102926bf57f21f33e2c45ff160ddfc68dd028dde 

Diff: https://git.reviewboard.kde.org/r/124580/diff/


Testing
-------

Changed my activity icon.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150802/761f518c/attachment.html>