Review Request 124585: Add pretty user switcher

[Heiko Tietze]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124585/#review83339
-----------------------------------------------------------


I would rather add a distict button for new session. But anyway please check the keyboard access. The current screen needs tab to switch between buttons (with tab between) and sessions (and arrow keys there) whereas the default log screen navigates with just left/right (and focuses the password input if relevant). And I wonder what happens when you have more sessions/users as can be shown on one screen. My expecxtation is some kind of chevron to indicate that there is more and to scroll through the list.

- Heiko Tietze


On Aug. 1, 2015, 10:38 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124585/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 10:38 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds a user switcher dialog borrowing elements from the lock screen and log out dialog. I never understood why KRunner was used for that.
> 
> It is not yet hooked up to the system (would make KRunner's "switchUser" interface forward that to KSMServer so everybody using it (eg. kickoff) would continue to work without adjustments). To test it run qdbus org.kde.ksmserver /KSMServer openSwitchUserDialog
> 
> When it opens it defaults to "New Session", from an interaction POV the list view behaves like the one on the lock screen.
> 
> It locks the screen when switching users only when the user has enabled the lock screen (might need a separate option for that?) That unconditional locking on session switching has turned out to be a major annoyance.
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt a0c8852 
>   ksmserver/org.kde.KSMServerInterface.xml 3680ed7 
>   ksmserver/server.h 2176aa1 
>   ksmserver/server.cpp b73b792 
>   ksmserver/switchuserdialog.h PRE-CREATION 
>   ksmserver/switchuserdialog.cpp PRE-CREATION 
>   lookandfeel/contents/components/UserList.qml 778d8ea 
>   lookandfeel/contents/components/UserSelect.qml 007a118 
>   lookandfeel/contents/userswitcher/UserSwitcher.qml e69de29 
> 
> Diff: https://git.reviewboard.kde.org/r/124585/diff/
> 
> 
> Testing
> -------
> 
> Looks pretty, switching to a new or existing session works.
> 
> Btw, weren't we able to click outside the dialog to dismiss it in 4.x? Seems broken for the logout dialog as well.
> 
> 
> File Attachments
> ----------------
> 
> User switcher
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/03dc2669-bee4-43a5-be11-350ba72417a6__fancyswitchuser1.jpg
> User switcher with icons
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/bb4d5a64-2ac5-4f61-9fd7-38d222a1f74f__fancyswitchuser2.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150802/0489aead/attachment.html>