Review Request 124585: Add pretty user switcher

Kai Uwe Broulik kde at privat.broulik.de
Sat Aug 1 22:02:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124585/
-----------------------------------------------------------

Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
-------

This adds a user switcher dialog borrowing elements from the lock screen and log out dialog. I never understood why KRunner was used for that.

How would I get the proper name and avatar of a user? Would also be cool if we could visually denote TTY or remote sessions (badge) in the list.

It is not yet hooked up to the system (would make KRunner's "switchUser" interface forward that to KSMServer) so everybody using it (eg. kickoff) would continue to work without adjustments. To test it run qdbus org.kde.ksmserver /KSMServer openSwitchUserDialog

When it opens it defaults to "New Session", from an interaction POV the list view behaves like the one on the lock screen.

Also, it does not yet lock the screen when switching. I do *not* want that thing to lock unconditionally, I've heard many people complain about that, including myself. It should follow the lock screen settings instead.


Diffs
-----

  ksmserver/CMakeLists.txt a0c8852 
  ksmserver/org.kde.KSMServerInterface.xml 3680ed7 
  ksmserver/server.h 2176aa1 
  ksmserver/server.cpp b73b792 
  ksmserver/switchuserdialog.h PRE-CREATION 
  ksmserver/switchuserdialog.cpp PRE-CREATION 
  lookandfeel/contents/components/UserList.qml 778d8ea 
  lookandfeel/contents/components/UserSelect.qml 007a118 
  lookandfeel/contents/userswitcher/UserSwitcher.qml e69de29 

Diff: https://git.reviewboard.kde.org/r/124585/diff/


Testing
-------

Looks pretty, switching to a new or existing session works.

Btw, weren't we able to click outside the dialog to dismiss it in 4.x? Seems broken for the logout dialog as well.


File Attachments
----------------

User switcher
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/03dc2669-bee4-43a5-be11-350ba72417a6__fancyswitchuser1.jpg


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150801/ae248a1d/attachment.html>


More information about the Plasma-devel mailing list