Review Request 123468: Add setting to adjust screen scaling

Kai Uwe Broulik kde at privat.broulik.de
Sat Aug 1 15:14:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123468/#review83301
-----------------------------------------------------------


When I initially open the dialog I don't get a preview and the label next to the slider says "TextLabel". Should probably set that initially? Also the Apply button doesn't get enabled, does it save the settings right away?

- Kai Uwe Broulik


On Aug. 1, 2015, 2:48 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123468/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 2:48 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kscreen
> 
> 
> Description
> -------
> 
> Single dialog alters both QT_DEVICE_PIXEL_RAITO and XRDB.DPI text
> scaling factor that used to reside in fonts KCM.
> 
> A preview widget shows how this will look on the that monitor.
> 
> Changes take affect after logout/login; not ideal but we're limited by
> the Qt QPA for now. Will try and fix that after.
> 
> edit: having uploaded this I can see I have some whitespace left, please don't feel the need to tell me.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e157a5e28e441a2e6dacb2d639cf6d120fb18c26 
>   kcm/src/CMakeLists.txt 50bfdf037c331fe7c6763fb85c3b43857cbea5d5 
>   kcm/src/previewwidget.h PRE-CREATION 
>   kcm/src/previewwidget.cpp PRE-CREATION 
>   kcm/src/scaling.ui PRE-CREATION 
>   kcm/src/scalingconfig.h PRE-CREATION 
>   kcm/src/scalingconfig.cpp PRE-CREATION 
>   kcm/src/stylepreview.ui PRE-CREATION 
>   kcm/src/widget.cpp 7fe96c1c8b21b19424ef4993dff9eb3985bcefdb 
> 
> Diff: https://git.reviewboard.kde.org/r/123468/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> the dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/a8cab37c-24bf-4fb9-b50b-39bc34596938__snapshot1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150801/3627215a/attachment.html>


More information about the Plasma-devel mailing list