Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

David Edmundson david at davidedmundson.co.uk
Sat Aug 1 12:08:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/
-----------------------------------------------------------

(Updated Aug. 1, 2015, 12:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 727852897203fb750d9a06f04b78b07527573948 by David Edmundson to branch master.


Repository: plasma-workspace


Description
-------

Show a dialog if Plasma failed to create an OpenGL Context.

remove that "shutup" option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly.


Diffs
-----

  shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 

Diff: https://git.reviewboard.kde.org/r/124576/diff/


Testing
-------

Normal plasma is the same as before.
I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150801/af4127cc/attachment.html>


More information about the Plasma-devel mailing list