Review Request 124571: add features from kcm_useraccounts
Jonathan Riddell
jr at jriddell.org
Sat Aug 1 09:36:30 UTC 2015
> On July 31, 2015, 10:56 p.m., David Edmundson wrote:
> > src/accountinfo.cpp, line 183
> > <https://git.reviewboard.kde.org/r/124571/diff/1/?file=388976#file388976line183>
> >
> > This is deprecated API
> >
> > http://doc.qt.io/qt-5/qdesktopservices-obsolete.html
> >
> > See QStandardPaths
I know but it's just a copy of the line 5 lines above, there's a bunch of stuff that needs ported to qt5/kf5
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124571/#review83270
-----------------------------------------------------------
On July 31, 2015, 9:17 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124571/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 9:17 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: user-manager
>
>
> Description
> -------
>
> Save settings with m_kEmailSettings as well to replace kcm_useraccounts
> add symlink in ~/.face.icon the file used by some login managers
>
> with this we can get rid of kcm_useraccounts which just duplicates it
>
>
> Diffs
> -----
>
> src/accountinfo.cpp 78fe969
> src/lib/accountmodel.h 331c131
> src/lib/accountmodel.cpp 558aa6b
>
> Diff: https://git.reviewboard.kde.org/r/124571/diff/
>
>
> Testing
> -------
>
> edited user settings and checked ~/.config/emailsettingsrc
>
> edited user settings and checked ~/.face*
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150801/fb210935/attachment.html>
More information about the Plasma-devel
mailing list