[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=346972

Andrew Lake <jamboarder at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|DUPLICATE                   |FIXED

--- Comment #6 from Andrew Lake <jamboarder at gmail.com> ---
Sorry, I maybe should not have marked this as duplicate. Let me explain.

The problem for the Breeze icon theme is that the rating icon was monochrome
black (Icon Grey technically). This was reported earlier against Breeze in bug
339863. During that bug review it was decided to re-assign it to KRatingPainter
and Christopher Feck attempted to update KRatingPainter to improve how it
handles monochrome low-saturation icons.  Unfortunately, despite Christopher's
effort, it somehow didn't work out. So the Breeze icon theme was updated to use
a yellow icon, which is similar to oxygen and so should work similar to Oxygen.

So while the problem is technically RESOLVED-FIXED for Breeze, KRatingPainter
might still have a little trouble with monochrome low-saturation icons until we
figure out why Christopher's patch didn't seem to work.

I'll change this to fixed for Breeze here. Hrvoje Senjan has already re-opened
the KRatingPainter bug 339863. If that bug gets resolved then we can update the
icon theme to take advantage of the fix to provide an even more distinct full
vs empty rating star icon.

Hope this helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.