Review Request 123544: kioclient ls: properly construct QUrl.

[Aleix Pol Gonzalez]

> On April 30, 2015, 1:02 a.m., Mark Gaiser wrote:
> > Pushed. But slightly different then was reviewed here.
> > I added the define which subsequently gave me two more issues of the same nature in kioclient (cat and openProperties).
> > I've fixed those as well and changed the commit message accordingly. Yes, i did test them before pushing and they seem to work just fine now.
> > 
> > http://quickgit.kde.org/?p=kde-cli-tools.git&a=commit&h=787bdf628fdf9f74c978363e07ddad0ae306d8bf

Wonderful. Thanks!


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123544/#review79701
-----------------------------------------------------------


On April 30, 2015, 12:56 a.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123544/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 12:56 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> The ls command was using direct user input as QUrl. That in turn caused the QUrl to be constructed without a scheme. Constructing it via makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows for example a command like "kioclient ls ~" to work again. Again because it worked in the kdelibs version thus this was a regression.
> 
> 
> Diffs
> -----
> 
>   kioclient/kioclient.cpp 74c9985 
> 
> Diff: https://git.reviewboard.kde.org/r/123544/diff/
> 
> 
> Testing
> -------
> 
> kioclient ls <path> works. No need to prefix the path with "file://" anymore.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150429/b0815ea1/attachment.html>