Review Request 123544: kioclient ls: properly construct QUrl.

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123544/
-----------------------------------------------------------

(Updated April 29, 2015, 10:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Faure.


Changes
-------

Submitted with commit 787bdf628fdf9f74c978363e07ddad0ae306d8bf by Mark Gaiser to branch master.


Repository: kde-cli-tools


Description
-------

The ls command was using direct user input as QUrl. That in turn caused the QUrl to be constructed without a scheme. Constructing it via makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows for example a command like "kioclient ls ~" to work again. Again because it worked in the kdelibs version thus this was a regression.


Diffs
-----

  kioclient/kioclient.cpp 74c9985 

Diff: https://git.reviewboard.kde.org/r/123544/diff/


Testing
-------

kioclient ls <path> works. No need to prefix the path with "file://" anymore.


Thanks,

Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150429/7be76afc/attachment.html>