Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123555/
-----------------------------------------------------------

(Updated April 29, 2015, 1:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Kai Uwe Broulik.


Changes
-------

Submitted with commit 08cbba07eb8927ce3a0f864eda8dfe1f8f1a6e44 by Emmanuel Pescosta to branch Plasma/5.3.


Repository: plasma-workspace


Description
-------

Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty.

Use QString::section instead of QString::split + QList::last (which requires a non empty list) to prevent the crash.

The crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop in this case)


IMO: Maybe the PowermanagementEngine should only add inhibitions from applications which have a non empty name?!


Diffs
-----

  dataengines/powermanagement/powermanagementengine.cpp 2fbf23f 

Diff: https://git.reviewboard.kde.org/r/123555/diff/


Testing
-------


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150429/944292c2/attachment.html>