Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123555/#review79666
-----------------------------------------------------------

Ship it!


Nice one!

Please commit to Plasma/5.3 and then merge into master.

- Kai Uwe Broulik


On April 29, 2015, 10:40 vorm., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123555/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 10:40 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty.
> 
> Use QString::section instead of QString::split + QList::last (which requires a non empty list) to prevent the crash.
> 
> The crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop in this case)
> 
> 
> IMO: Maybe the PowermanagementEngine should only add inhibitions from applications which have a non empty name?!
> 
> 
> Diffs
> -----
> 
>   dataengines/powermanagement/powermanagementengine.cpp 2fbf23f 
> 
> Diff: https://git.reviewboard.kde.org/r/123555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150429/8c5ff93c/attachment.html>