Review Request 123544: kioclient ls: properly construct QUrl.

[Mark Gaiser]

> On apr 28, 2015, 7:11 p.m., Aleix Pol Gonzalez wrote:
> > Can you add add_definitions(-DQT_NO_URL_CAST_FROM_STRING)?
> > 
> > That will help spotting these issues.

Ok, will add that and commit later tonight or tomorrow.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123544/#review79645
-----------------------------------------------------------


On apr 28, 2015, 6:18 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123544/
> -----------------------------------------------------------
> 
> (Updated apr 28, 2015, 6:18 p.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> The ls command was using direct user input as QUrl. That in turn caused the QUrl to be constructed without a scheme. Constructing it via makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows for example a command like "kioclient ls ~" to work again. Again because it worked in the kdelibs version thus this was a regression.
> 
> 
> Diffs
> -----
> 
>   kioclient/kioclient.cpp 74c9985 
> 
> Diff: https://git.reviewboard.kde.org/r/123544/diff/
> 
> 
> Testing
> -------
> 
> kioclient ls <path> works. No need to prefix the path with "file://" anymore.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150428/2fd2624f/attachment-0001.html>