Review Request 123473: Port mouse theme kcm to QML

Marco Martin notmart at gmail.com
Tue Apr 28 13:16:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/
-----------------------------------------------------------

(Updated April 28, 2015, 1:16 p.m.)


Review request for Plasma and KDE Usability.


Changes
-------

this latest version should be ok enough, tested cursor change, download/install/uninstall, all seems to work well


Repository: plasma-desktop


Description
-------

This is more an experiment on how much modules can be closely ported (and in how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well


Diffs (updated)
-----

  applets/icontasks/metadata.desktop f0b237c 
  containments/folder/metadata.desktop a6d08a7 
  kcms/access/kcmaccess.desktop 825b6d7 
  kcms/baloo/kcm_baloofile.desktop 2eee6fc 
  kcms/cursortheme/CMakeLists.txt 83f3ba2 
  kcms/cursortheme/Messages.sh 79450c7 
  kcms/cursortheme/cursortheme.desktop f443208 
  kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
  kcms/cursortheme/kcmcursortheme.h d9e32b2 
  kcms/cursortheme/kcmcursortheme.cpp 44576ff 
  kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
  kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
  kcms/cursortheme/package/metadata.desktop PRE-CREATION 
  kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
  kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
  kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
  kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
  kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
  kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
  kcms/cursortheme/xcursor/thememodel.h bcf046a 
  kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
  kcms/cursortheme/xcursor/themepage.h 98c69fd 
  kcms/cursortheme/xcursor/themepage.cpp 687bd65 
  kcms/cursortheme/xcursor/themepage.ui 6efe60b 
  kcms/desktoppaths/desktoppath.desktop eb2fad5 
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
  kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
  kcms/lookandfeel/package/metadata.desktop 6595d6e 
  kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
  kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
  kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
  kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
  kcms/useraccount/kcm_useraccount.desktop 46ef110 
  layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3 

Diff: https://git.reviewboard.kde.org/r/123473/diff/


Testing
-------


File Attachments
----------------

cursorskcm.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150428/6360f0a5/attachment.html>


More information about the Plasma-devel mailing list