Review Request 123537: Add support for menu sections

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123537/#review79598
-----------------------------------------------------------



src/declarativeimports/plasmacomponents/qmenu.cpp (line 196)
<https://git.reviewboard.kde.org/r/123537/#comment54383>

    I added an isVisible check before this (and above), so you could conditionally show sections using bindings, eg. so "Recent documents for" is only shown when documents exist.


- Kai Uwe Broulik


On April 27, 2015, 8:20 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123537/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 8:20 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> QMenuItem now has a "section" property that makes it behave like a section. I did not find a removeSection method, however.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qmenu.h a927d12 
>   src/declarativeimports/plasmacomponents/qmenu.cpp 0b82a99 
>   src/declarativeimports/plasmacomponents/qmenuitem.h f8629f0 
>   src/declarativeimports/plasmacomponents/qmenuitem.cpp aa61288 
>   tests/components/menu.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123537/diff/
> 
> 
> Testing
> -------
> 
> Seems to work fine, icons are not supported, comes with a manual test.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150427/4dade7fc/attachment.html>