Review Request 123501: Improve suspended job appearance

David Edmundson david at davidedmundson.co.uk
Sat Apr 25 23:52:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123501/#review79523
-----------------------------------------------------------

Ship it!



applets/notifications/package/contents/ui/JobDelegate.qml (line 155)
<https://git.reviewboard.kde.org/r/123501/#comment54330>

    do you maybe want to put this part of the change in 5.3?


- David Edmundson


On April 25, 2015, 9:26 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123501/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 9:26 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Today I noticed that a paused job is not really obvious, other than the tiny pause button turning into a play button. This adds "(Paused)" to the title, such as "Copying (Paused)" in that case. Also turns off the indeterminate animation then since it's not really doing anything.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/JobDelegate.qml f3f091d 
> 
> Diff: https://git.reviewboard.kde.org/r/123501/diff/
> 
> 
> Testing
> -------
> 
> Works fine
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150425/5976591a/attachment.html>


More information about the Plasma-devel mailing list