Review Request 123493: Fix leaky incubation controller

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123493/#review79481
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On April 24, 2015, 6:43 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123493/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Docs for QQmlEngine explcitly say
> 
> "The engine can only have one active controller and it does not take
> ownership of it." therefore we need to set a parent.
> 
> The incubator controls the deletion of generated objects, so this means we're leaking all QML items created by the KDeclarative::QmlObject.
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/qmlobject.cpp c483665c43985ba57459a880895ee8bf7ff92041 
> 
> Diff: https://git.reviewboard.kde.org/r/123493/diff/
> 
> 
> Testing
> -------
> 
> Plasma shell still loads and runs fine. Valgrind is a lot less angry.
> Will merge after 5.10 to play safe.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150425/11acff79/attachment-0001.html>