Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

Antonis Tsiapaliokas antonis.tsiapaliokas at kde.org
Fri Apr 24 18:24:18 UTC 2015



> On April 22, 2015, 3:46 a.m., Kai Uwe Broulik wrote:
> > -1
> > 
> > that's what the visible: pmSource.data["Battery"]["Has Cumulative"] is for. there just used to be a bug where that property wasn't created in the first place if no battery was present leading to an exception causing the item to remain visible.

What about checking if the "pmSource.data["Battery"]["Has Cumulative"]" has been set properly, and if not, then using the pmSource.data["Battery"]["Has Battery"]?
I have update my patch with the above change...


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123459/#review79321
-----------------------------------------------------------


On April 24, 2015, 6:22 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123459/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346441
>     https://bugs.kde.org/show_bug.cgi?id=346441
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery).
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/components/InfoPane.qml 18739ad 
> 
> Diff: https://git.reviewboard.kde.org/r/123459/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> no battery after
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png
> no battery before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150424/cd8618c3/attachment.html>


More information about the Plasma-devel mailing list