Review Request 123473: Port mouse theme kcm to QML

[Eike Hein]

> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
>     none.
>     not too much pain as well tough.
>     all of them have to eventually be ported tough and in order to get done, one has to.. do it

> all of them have to eventually be ported tough and in order to get done, one has to.. do it

I'm just not a big fan of putting transitional pain (worse UI from a weaker toolkit) on the user when there's an opportunity to avoid it, I guess ... right now, Qt Quick has worse performance, no keyboard accelerator management, no form layouts, limited widgets, some visual problems, etc. - It's true of course that using it builds greater pressure to get it fixed, but are we *certain* that actively hurting the quality of our releases is the only path available?


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
-----------------------------------------------------------


On April 23, 2015, 11 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is more an experiment on how much modules can be closely ported (and in how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the QtQuickControls ComboBox being very limited and without a customizable delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -----
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> cursorskcm.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150423/4d6975ae/attachment.html>