Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123467/#review79349
-----------------------------------------------------------


The idea sounds, some nitpicks though.


libs/mediacenter/mpris2/mpris2.cpp (line 33)
<https://git.reviewboard.kde.org/r/123467/#comment54195>

    Hardcoding '/' might not be portable, try using QDir's features to get what you want. I'd prefer having a class QDir var which is initialized to the full path (till covers/) in the ctor.



libs/mediacenter/mpris2/mpris2.cpp (line 104)
<https://git.reviewboard.kde.org/r/123467/#comment54197>

    Make this a member as suggested above.



libs/mediacenter/mpris2/mpris2.cpp (lines 106 - 108)
<https://git.reviewboard.kde.org/r/123467/#comment54196>

    Using the QDir member as suggested above, call absoluteFilePath instead of doing a string concatenate.


- Shantanu Tushar


On April 22, 2015, 1:44 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123467/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 1:44 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Save Cover art to a temperoray folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces.
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/mpris2/mpris2.cpp f03d062 
> 
> Diff: https://git.reviewboard.kde.org/r/123467/diff/
> 
> 
> Testing
> -------
> 
> Correct path is showing up in the metadata when tested with mpristester.
> Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150422/dd906af7/attachment.html>