Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

[Nerdopolis Turfwalker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123411/
-----------------------------------------------------------

(Updated April 22, 2015, 12:05 a.m.)


Review request for Plasma.


Changes
-------

give m_rows a default value of the lowest number of rows supported by the pager


Repository: plasma-desktop


Description
-------

Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland


Diffs (updated)
-----

  applets/pager/plugin/pager.h 78d461d2554e4885721da3d2eff82151c97f9305 
  applets/pager/plugin/pager.cpp 22c6ca2747f297dc3d37d02b46cb33196e64b1e0 

Diff: https://git.reviewboard.kde.org/r/123411/diff/


Testing
-------

Ran plasmoidviewer -a org.kde.plasma.pager in with QT_QPA_PLATFORM=wayland got no crash from plasmoid viewer.

Started an Xephyr session, set QT_QPA_PLATFORM=xcb and DISPLAY=:1, started kwin_x11, and then plasmoidviewer -a org.kde.plasma.pager and had full functionality.


Thanks,

Nerdopolis Turfwalker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150422/4917b641/attachment.html>