Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

Antonis Tsiapaliokas antonis.tsiapaliokas at kde.org
Tue Apr 21 20:30:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123448/
-----------------------------------------------------------

(Updated April 21, 2015, 8:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 8d6a08416f95ce8b346d205fd4bdab3692ce24de by Antonis Tsiapaliokas to branch master.


Bugs: 346431
    https://bugs.kde.org/show_bug.cgi?id=346431


Repository: plasma-desktop


Description
-------

The "Wallpaper" and the  "Mouse Actions" category should always show
the message dialog if they have pending changes.

Futhermore there is no need to check if there are pending changes,
since we already know that because of the "Apply" Button.
So we don't need the  "configurationHasChanged" function anymore.


Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad 

Diff: https://git.reviewboard.kde.org/r/123448/diff/


Testing
-------


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150421/a4ce4a39/attachment.html>


More information about the Plasma-devel mailing list