Review Request 123405: Remove broken option to show 3 characters for every keypress in passwords
David Edmundson
david at davidedmundson.co.uk
Fri Apr 17 21:17:30 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123405/
-----------------------------------------------------------
(Updated April 17, 2015, 9:17 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 7b2780d787e3a14eab7fc473dde993726d04258c by David Edmundson to branch Plasma/5.3.
Repository: plasma-desktop
Description
-------
It doesn't work on QLineEdits, it doesn't work on QtQuick TextFields,
and it can never work. Given most our main password promptes are QtQuick
TextFields this is a problem.
Having an option that doesn't work is worse than not having an option, especially when the feature is already rather esoteric so I've just removed it.
Diffs
-----
kcms/useraccount/CMakeLists.txt 96d2ea8
kcms/useraccount/kcm_useraccount_pass.kcfg c76e4a6
kcms/useraccount/main.cpp 32c76fe
kcms/useraccount/main_widget.ui 3b0f0d8
kcms/useraccount/pass.kcfgc 21b4bb7
Diff: https://git.reviewboard.kde.org/r/123405/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150417/cd0f9d07/attachment.html>
More information about the Plasma-devel
mailing list