Review Request 123332: Timer: Added config ui for notification and title text

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123332/#review79145
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On April 17, 2015, 8:02 p.m., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123332/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 8:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Added config ui for specifying a title text
> Added config ui for disabling the notification (default: enabled)
> Added config ui for configuring the notification text
> 
> 
> Diffs
> -----
> 
>   applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc 
>   applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 
>   applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 
>   applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 
> 
> Diff: https://git.reviewboard.kde.org/r/123332/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Appearance Tab showing defaults
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/17/f133b83a-c8bd-4cbb-b1d1-2757b3016fd1__tab_appearance_default.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150417/9324ef25/attachment.html>