Review Request 123378: Krunner results shouldn't follow showAppsByName

Vishesh Handa me at vhanda.in
Fri Apr 17 12:00:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123378/#review79115
-----------------------------------------------------------


Seems reasonable.

- Vishesh Handa


On April 15, 2015, 10:13 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123378/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 10:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Krunner results shouldn't follow showAppsByName
>     
>     Currently krunner follows the config show apps by name setting however
>     given krunner results are returned with the names/subtitles backwards to
>     other models it already doesn't work; showing the real name first with
>     the default setting.
>     
>     If you then enable showAppByName we get things not shown by name; and we
>     mess every other search result type.
>     
>     BUG: 345926
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/KickoffItem.qml f48d53b 
>   applets/kickoff/package/contents/ui/SearchView.qml d1ff6d7 
> 
> Diff: https://git.reviewboard.kde.org/r/123378/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150417/5f6618e1/attachment.html>


More information about the Plasma-devel mailing list