Review Request 123299: Kickoff - Watch changes in the recent documents directory

Anthony Vital anthony.vital at gmail.com
Thu Apr 16 21:10:02 UTC 2015



> On avr. 16, 2015, 8:46 après-midi, Sebastian Kügler wrote:
> > applets/kickoff/core/recentlyusedmodel.cpp, line 113
> > <https://git.reviewboard.kde.org/r/123299/diff/1/?file=360493#file360493line113>
> >
> >     Why this change?

Because documentUrl doesn't exist anymore, so I didn't want to leave it like that even if it's commented. I replaced it with something similar for debugging purpose.
Should I remove the line completely instead?


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123299/#review79079
-----------------------------------------------------------


On avr. 8, 2015, 3:43 après-midi, Anthony Vital wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123299/
> -----------------------------------------------------------
> 
> (Updated avr. 8, 2015, 3:43 après-midi)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Watch changes in the recent documents directory
> 
> Fixes a bug when you opened a document already present in the recent docs list, the document wasn't moved at the top of the list.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/recentlyusedmodel.h 44bcc9f091832a15524b17211739b3b1da0a27fa 
>   applets/kickoff/core/recentlyusedmodel.cpp a5a19ca8cac09e2fb2dca64b1dbfcc7085322ebf 
> 
> Diff: https://git.reviewboard.kde.org/r/123299/diff/
> 
> 
> Testing
> -------
> 
> Opened documents already in the recent documents list, they now appear at the top.
> 
> 
> Thanks,
> 
> Anthony Vital
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150416/a473ac44/attachment.html>


More information about the Plasma-devel mailing list