Review Request 123386: Fix i18n catalog connection of a string in shortcuts config

David Edmundson david at davidedmundson.co.uk
Thu Apr 16 17:19:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123386/#review79067
-----------------------------------------------------------

Ship it!


I don't think there's another way

- David Edmundson


On April 16, 2015, 5:16 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123386/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 5:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is a bit ugly and prone to breaking if the catalog is ever renamed, but I don't know of a better way. Also this way is already used elsewhere and for this same catalog.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/ConfigurationShortcuts.qml ca37ed1 
> 
> Diff: https://git.reviewboard.kde.org/r/123386/diff/
> 
> 
> Testing
> -------
> 
> Checked that the translation of the string was displayed correctly.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150416/e05546e8/attachment.html>


More information about the Plasma-devel mailing list