Review Request 123382: System tray: Show more than 8 entries.

[Aleix Pol Gonzalez]

> On April 16, 2015, 1:42 p.m., Kai Uwe Broulik wrote:
> > What about just wrapping it in a ScrollView rather than plain flickable so you get scrollbars that make it obvious there's more?
> 
> Marco Martin wrote:
>     i would be fine with that as well
> 
> Sebastian Kügler wrote:
>     +1 for scrollview.

It could look quite cramped...
What about having N rows of icons?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123382/#review79044
-----------------------------------------------------------


On April 16, 2015, 1:32 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123382/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 1:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 341165
>     https://bugs.kde.org/show_bug.cgi?id=341165
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When there are more than 8 hidden items in the system tray, the system tray doesn't show the rest.
> This patch is changing the default height of the system tray based on the total count of all of our entries.
> So if all of our entries become hidden, we will still have enought space to show all of them.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/main.qml fd59a14 
> 
> Diff: https://git.reviewboard.kde.org/r/123382/diff/
> 
> 
> Testing
> -------
> 
> Everything works fine.
> The opacity in the screenshots is because the popup is losing the focus..
> 
> 
> File Attachments
> ----------------
> 
> system tray with less items
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/16/ec87e90e-697b-4eaf-8ed6-d37501a18b90__systemtray.png
> system tray with more items
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/16/0067ff99-ec2f-4a74-a310-57c16f06f256__systemtray2.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150416/f3b41042/attachment.html>